-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding native otel logs collection for windows nodes #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Jan 19, 2022
dmitryax
reviewed
Jan 20, 2022
dmitryax
reviewed
Jan 20, 2022
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
nitaliya
force-pushed
the
otel_logsengine_win
branch
from
January 20, 2022 05:28
441d997
to
e9c7f5c
Compare
dmitryax
reviewed
Jan 20, 2022
nitaliya
force-pushed
the
otel_logsengine_win
branch
from
January 20, 2022 05:43
1bae0a7
to
ab82195
Compare
nitaliya
force-pushed
the
otel_logsengine_win
branch
from
January 20, 2022 05:44
ab82195
to
911e929
Compare
dmitryax
reviewed
Jan 20, 2022
dmitryax
reviewed
Jan 20, 2022
Co-authored-by: Dmitrii Anoshin <[email protected]>
Co-authored-by: Dmitrii Anoshin <[email protected]>
dmitryax
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native logs support on windows k8s nodes
Ticket: OTL-1349
Changes:
$$attributes["file.path"]
initContainers
in case of windows k8s nodes, because fluentd logging agent is not supported on a windows nodeTesting outcome:
For testing, I have used the following values.yaml input file to Otel helm chart
to generate a log I have created a sample deployment to print random numbers on the log file.
Output:
Console log of otel-collector agent.
Splunk Log Observer.