Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding native otel logs collection for windows nodes #361

Merged
merged 5 commits into from
Jan 20, 2022

Conversation

nitaliya
Copy link
Contributor

@nitaliya nitaliya commented Jan 19, 2022

Native logs support on windows k8s nodes
Ticket: OTL-1349

Changes:

  • Updating filelog path and regex to parse windows $$attributes["file.path"]
  • Not creating initContainers in case of windows k8s nodes, because fluentd logging agent is not supported on a windows node
  • Mounting C:/ProgramData of the host as var-lib-docker-containers in case of windows k8s nodes

Testing outcome:
For testing, I have used the following values.yaml input file to Otel helm chart

clusterName: nimesh-windows-cluster
splunkObservability:
  realm: <SPLUNK_REALM>
  accessToken: <SPLUNK_ACCESS_TOKEN>
  logsEnabled: true

image:
  otelcol:
    repository: quay.io/signalfx/splunk-otel-collector-windows-dev

logsEngine: "otel"
readinessProbe:
  initialDelaySeconds: 60
livenessProbe:
  initialDelaySeconds: 60

isWindows: true

agent:
  config:
    exporters:
      logging:
        loglevel: debug
    service:
      pipelines:
        logs:
          exporters: [ logging, splunk_hec/o11y ]

to generate a log I have created a sample deployment to print random numbers on the log file.

Output:
Console log of otel-collector agent.
Screenshot 2022-01-19 at 4 11 51 PM

Splunk Log Observer.
Screenshot 2022-01-19 at 4 09 40 PM

@nitaliya nitaliya requested review from a team as code owners January 19, 2022 11:00
@nitaliya nitaliya requested a review from dmitryax January 20, 2022 04:20
@nitaliya nitaliya force-pushed the otel_logsengine_win branch from 441d997 to e9c7f5c Compare January 20, 2022 05:28
@nitaliya nitaliya force-pushed the otel_logsengine_win branch from 1bae0a7 to ab82195 Compare January 20, 2022 05:43
@nitaliya nitaliya force-pushed the otel_logsengine_win branch from ab82195 to 911e929 Compare January 20, 2022 05:44
examples/README.md Outdated Show resolved Hide resolved
@nitaliya nitaliya requested a review from dmitryax January 20, 2022 06:02
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dmitryax dmitryax merged commit 8058aa2 into signalfx:main Jan 20, 2022
@nitaliya nitaliya deleted the otel_logsengine_win branch January 20, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants