Add helm hook for custom secret validation #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
add-secret-validation
branch
from
5ca3ab0 to
9a07add
Compare
rockb1017
reviewed
Nov 16, 2021
| - name: validate-secret | ||
| image: {{ template "splunk-otel-collector.image.otelcol" . }} | ||
| imagePullPolicy: {{ .Values.image.otelcol.pullPolicy }} | ||
| command: ["sh", "-c"] |
There was a problem hiding this comment.
this image doesn't have sh, no?
There was a problem hiding this comment.
oh i see it does. but how? just curious.
There was a problem hiding this comment.
It's being picked up from signalfx-agent bundle https://github.com/signalfx/signalfx-agent/blob/main/Dockerfile#L306-L332
dmitryax
force-pushed
the
add-secret-validation
branch
from
9a07add to
3acac4e
Compare
rockb1017
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #295