Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit default checkpoint path #292

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Conversation

rockb1017
Copy link
Contributor

To make deployment in Autopilot work out of the box

@rockb1017 rockb1017 requested review from a team as code owners November 16, 2021 07:31
@dmitryax
Copy link
Contributor

We also need to add a copy command in the initContainer to avoid re-reading all the logs on upgrade. There are few Observability customers using the native logs collection

@rockb1017
Copy link
Contributor Author

We also need to add a copy command in the initContainer to avoid re-reading all the logs on upgrade. There are few Observability customers using the native logs collection

hmm so mount both directories and copy files if it doesn't already exist in the new path?

@rockb1017
Copy link
Contributor Author

I am using cp -n for no overwrite. and making sure it always exit 0 with || true

-n, --no-clobber
              do not overwrite an existing file (overrides a previous -i option)

@rockb1017 rockb1017 force-pushed the checkpoint-path branch 2 times, most recently from 4d38610 to f8979ec Compare November 16, 2021 18:48
CHANGELOG.md Outdated Show resolved Hide resolved
@rockb1017 rockb1017 requested a review from dmitryax November 17, 2021 06:53
@dmitryax dmitryax merged commit b86ddb7 into signalfx:main Nov 17, 2021
@dmitryax
Copy link
Contributor

dmitryax commented Nov 17, 2021

@rockb1017 Follow-up: we have the checkpointPath configuration option but all the initContainers use hardcoded /var/addon/splunk/otel_pos value instead.

I believe changing checkpointPath may break the chart installation. We need to decide how to solve it:

  1. Make sure checkpointPath is used in all initContainers
  2. Remove checkpointPath option and use hardcoded values instead.

I vote for 2. We can always bring that configuration back if there will be a need. Please let me know what do you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants