Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated sourcetype precedence order #276

Merged
merged 4 commits into from
Nov 12, 2021
Merged

updated sourcetype precedence order #276

merged 4 commits into from
Nov 12, 2021

Conversation

luckyj5
Copy link
Contributor

@luckyj5 luckyj5 commented Nov 11, 2021

updated sourcetype precedence order:

  • Sourcetype defined via Pod annotation [1]
  • Sourcetype defined via optional config param in helm chart values [2]
  • K8s metadata: “kube:container:<CONTAINER_NAME>” for container logs [3]
  • Sourcetype for non-container logs/ extrafiles: "defined by the user in the config" [4]

@luckyj5 luckyj5 requested review from a team as code owners November 11, 2021 18:56
@dmitryax
Copy link
Contributor

LGTM. We probably should remove sourcetype field from splunk_hec/platform_logs and splunk_hec/platform_metrics exporters since they don't have any effect anymore.

@luckyj5
Copy link
Contributor Author

luckyj5 commented Nov 11, 2021

LGTM. We probably should remove sourcetype field from splunk_hec/platform_logs and splunk_hec/platform_metrics exporters since they don't have any effect anymore.

Thanks @dmitryax.
PR updated to remove not used sourcetype fields.

dmitryax
dmitryax approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @rockb1017 can you please take a look as well?

rockb1017
rockb1017 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@rockb1017 rockb1017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dmitryax dmitryax merged commit ba99852 into signalfx:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockb1017 rockb1017 rockb1017 approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luckyj5 @dmitryax @rockb1017