Fetch all attributes #273
Merged
Fetch all attributes #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockb1017
suggested changes
Nov 11, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl
Outdated
Show resolved
Hide resolved
rockb1017
suggested changes
Nov 12, 2021
chaitanyaphalak
force-pushed
the
fetch-all-attributes
branch
from
068656e to
c7d90eb
Compare
rockb1017
suggested changes
Nov 12, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl
Outdated
Show resolved
Hide resolved
rockb1017
previously approved these changes
Nov 12, 2021
dmitryax
reviewed
Nov 12, 2021
chaitanyaphalak
force-pushed
the
fetch-all-attributes
branch
2 times, most recently
from
b24279e to
17e73c0
Compare
rockb1017
reviewed
Nov 16, 2021
dmitryax
reviewed
Nov 16, 2021
chaitanyaphalak
force-pushed
the
fetch-all-attributes
branch
from
f3993f6 to
dbd80f0
Compare
dmitryax
reviewed
Nov 17, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Nov 17, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
chaitanyaphalak
force-pushed
the
fetch-all-attributes
branch
from
4672c36 to
b9004fc
Compare
rockb1017
approved these changes
Nov 17, 2021
dmitryax
reviewed
Nov 17, 2021
chaitanyaphalak
force-pushed
the
fetch-all-attributes
branch
from
b9004fc to
f9dc073
Compare
chaitanyaphalak
force-pushed
the
fetch-all-attributes
branch
from
cbd60c7 to
c432fd2
Compare
|
Hi! Great work with all the changes in 0.38.0, I really appreciate the semantic changes to make Values easier to follow. I have a question, however. I see from your comments that there exists fields Is this documented elsewhere, so I can understand more about this syntax and valid values? Are there more fields than those three, and can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch namespace and pods labels and annotations