Add include logs functionality #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Nov 1, 2021
dmitryax
reviewed
Nov 1, 2021
dmitryax
reviewed
Nov 1, 2021
dmitryax
reviewed
Nov 1, 2021
dmitryax
reviewed
Nov 1, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl
Outdated
Show resolved
Hide resolved
chaitanyaphalak
force-pushed
the
add-include-logs-funtionality
branch
from
b815799 to
65bbafe
Compare
dmitryax
reviewed
Nov 2, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
chaitanyaphalak
force-pushed
the
add-include-logs-funtionality
branch
2 times, most recently
from
0c0afbc to
0d524e8
Compare
dmitryax
reviewed
Nov 2, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
chaitanyaphalak
force-pushed
the
add-include-logs-funtionality
branch
3 times, most recently
from
bdcb2d0 to
9282502
Compare
dmitryax
reviewed
Nov 9, 2021
chaitanyaphalak
force-pushed
the
add-include-logs-funtionality
branch
from
b39d2af to
39fb832
Compare
|
Hey @dmitryax , updated the PR, with your latest recommendations, lint-test is failing due to some fluentd error, I am not sure why? |
dmitryax
reviewed
Nov 11, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
chaitanyaphalak
force-pushed
the
add-include-logs-funtionality
branch
3 times, most recently
from
27a8537 to
e601539
Compare
dmitryax
approved these changes
Nov 13, 2021
dmitryax
reviewed
Nov 15, 2021
chaitanyaphalak
force-pushed
the
add-include-logs-funtionality
branch
2 times, most recently
from
7b81515 to
d02e21f
Compare
dmitryax
reviewed
Nov 17, 2021
chaitanyaphalak
force-pushed
the
add-include-logs-funtionality
branch
from
9b8feff to
fe2a7e4
Compare
dmitryax
reviewed
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set splunk.com/include annotation to true on pod and .Values.logsCollection.containers.useSplunkIncludeAnnotation flag to true to include its logs from ingested to your Splunk platform deployment.
All other logs will be ignored.