field name compatibility for SCK #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockb1017
force-pushed
the
field_name_compat
branch
3 times, most recently
from
0fd335d to
e17c5ff
Compare
dmitryax
reviewed
Oct 30, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
rockb1017
force-pushed
the
field_name_compat
branch
4 times, most recently
from
0d4ea2c to
0606bbf
Compare
rockb1017
force-pushed
the
field_name_compat
branch
from
0606bbf to
89dd2f1
Compare
dmitryax
reviewed
Nov 2, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
rockb1017
force-pushed
the
field_name_compat
branch
2 times, most recently
from
fdd50a2 to
5d9d816
Compare
rockb1017
changed the title
rockb1017
force-pushed
the
field_name_compat
branch
from
5d9d816 to
b127162
Compare
dmitryax
reviewed
Nov 2, 2021
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Nov 2, 2021
dmitryax
reviewed
Nov 3, 2021
Co-authored-by: Dmitrii Anoshin <[email protected]>
|
Thank you so much for detailed review! |
dmitryax
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backward compatible field names for container metadata.