Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of kubernetes-events monitor #187

Merged
merged 4 commits into from
Sep 9, 2021
Merged

Adding support of kubernetes-events monitor #187

merged 4 commits into from
Sep 9, 2021

Conversation

nitaliya
Copy link
Contributor

@nitaliya nitaliya commented Aug 31, 2021

Description:
Helm chart changes to make support of kubernetes-events monitor.
Ticket : OTL-951
Following activities/changes done in this PR.

  • Adding MY_NAMESPACE, MY_NODE_NAME environmental variables to the DaemonSet and Deployment.
  • Adding permissions for writing to configmaps

I am attaching logs of otel-collector container for reference of the testing output of the above changes.
Screenshot 2021-08-31 at 4 51 02 PM

@nitaliya nitaliya requested review from a team as code owners August 31, 2021 12:08
@nitaliya nitaliya changed the title Adding support of kubernetes-events monitor Adding support of kubernetes-cluster monitor Sep 7, 2021
@nitaliya nitaliya changed the title Adding support of kubernetes-cluster monitor Adding support of kubernetes-events monitor Sep 8, 2021
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. please add a line to the CHANGELOG.md and we can merge it

@dmitryax dmitryax merged commit 4f000ea into signalfx:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants