Add missing attributes to self-scraping prometheus metrics #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fix-prom-metrics
branch
3 times, most recently
from
8fc7f99 to
c9a5330
Compare
Prometheus metrics reported by gateway and k8s-cluster-receiver collector deployments are missing k8s and host related attributes. This commit is to make sure that all the self-scraping prometheus metrics have all the required attributes.
dmitryax
force-pushed
the
fix-prom-metrics
branch
from
c9a5330 to
1f61619
Compare
jrcamp
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus metrics reported by gateway and k8s-cluster-receiver collector deployments are missing k8s and host related attributes. This commit is to make sure that all the self-scraping prometheus metrics have all the required attributes.