Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove networkExplorer option #1156

Merged
merged 1 commit into from
Feb 16, 2024
Merged

remove networkExplorer option #1156

merged 1 commit into from
Feb 16, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 13, 2024

Description:
Remove networkExplorer option from the chart. This option was first deprecated in 0.88.0.

@atoulme atoulme force-pushed the remove_networkexplorer branch from c7765a2 to c9e7ba8 Compare February 13, 2024 00:23
@atoulme atoulme marked this pull request as ready for review February 13, 2024 00:54
@atoulme atoulme requested review from a team as code owners February 13, 2024 00:54
UPGRADING.md Show resolved Hide resolved
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with either: removing the section now and fail if the option is provided or just fixing the reported issue and keep the second warning for longer. Probably a product call

@atoulme
Copy link
Contributor Author

atoulme commented Feb 14, 2024

OK we will first remove the use in 0.93.1, and keep this PR open for 0.94.0.

@atoulme atoulme force-pushed the remove_networkexplorer branch from 98de28e to 6f33ea7 Compare February 16, 2024 22:23
@atoulme atoulme merged commit 031f5ba into main Feb 16, 2024
32 checks passed
@atoulme atoulme deleted the remove_networkexplorer branch February 16, 2024 22:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants