Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Splunk .NET docker image to the chart #1098

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Add Splunk .NET docker image to the chart #1098

merged 4 commits into from
Jan 18, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 2, 2024

Description:
Add Splunk .NET docker image to the chart. Add to rotation for image updates.

@atoulme atoulme requested review from a team as code owners January 2, 2024 18:04
Copy link

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to wait for us to publish the Docker image.

helm-charts/splunk-otel-collector/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you are missing, one important thing.
Operator has to setup env. var.: "OTEL_DOTNET_AUTO_PLUGINS": "Splunk.OpenTelemetry.AutoInstrumentation.Plugin, Splunk.OpenTelemetry.AutoInstrumentation"

Otherwise it will be working us Vanilla/upstream distribution.

There will be no support for RUM, realms/splunk access key, AlwaysOn Profiling (in progress), come gdi-config requierments.

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, but didn't have chance to test it E2E. I hope you have did it.

Two more thing

  1. Should we update our procedure to include changes in this repository? https://github.com/signalfx/splunk-otel-dotnet/blob/608f45e960eb6f6af55c0554a21e40527f20faa8/RELEASING.md Or it willl be on your side? What is the typical scenario?
  2. Minor comment related to the changelog entry.

.chloggen/adddotnetimage.yaml Outdated Show resolved Hide resolved
Co-authored-by: Piotr Kiełkowicz <[email protected]>
@atoulme
Copy link
Contributor Author

atoulme commented Jan 5, 2024

Should we update our procedure to include changes in this repository? https://github.com/signalfx/splunk-otel-dotnet/blob/608f45e960eb6f6af55c0554a21e40527f20faa8/RELEASING.md Or it willl be on your side? What is the typical scenario?
We run a cron job to pick up new versions, and open a PR automatically. We do this for java and nodejs already. This PR adds the dotnet image to the rotation.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 11, 2024

Should we add a test application similar to node.js? @jvoravong wdyt?

@jvoravong
Copy link
Contributor

Was able to verify the Splunk .NET docker image works e2e. There is an issue in .NET environments where the exporter endpoint isn't always respected properly which I will address in #1117.

Merging this PR now.

@jvoravong jvoravong merged commit 0d36758 into main Jan 18, 2024
31 of 32 checks passed
@jvoravong jvoravong deleted the add_dotnet_image branch January 18, 2024 00:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants