-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Splunk .NET docker image to the chart #1098
Conversation
7e732f5
to
e4aa615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to wait for us to publish the Docker image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you are missing, one important thing.
Operator has to setup env. var.: "OTEL_DOTNET_AUTO_PLUGINS": "Splunk.OpenTelemetry.AutoInstrumentation.Plugin, Splunk.OpenTelemetry.AutoInstrumentation"
Otherwise it will be working us Vanilla/upstream distribution.
There will be no support for RUM, realms/splunk access key, AlwaysOn Profiling (in progress), come gdi-config requierments.
fe3dee4
to
453cd22
Compare
453cd22
to
d76de7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me, but didn't have chance to test it E2E. I hope you have did it.
Two more thing
- Should we update our procedure to include changes in this repository? https://github.com/signalfx/splunk-otel-dotnet/blob/608f45e960eb6f6af55c0554a21e40527f20faa8/RELEASING.md Or it willl be on your side? What is the typical scenario?
- Minor comment related to the changelog entry.
Co-authored-by: Piotr Kiełkowicz <[email protected]>
|
Co-authored-by: jvoravong <[email protected]>
Should we add a test application similar to node.js? @jvoravong wdyt? |
Was able to verify the Splunk .NET docker image works e2e. There is an issue in .NET environments where the exporter endpoint isn't always respected properly which I will address in #1117. Merging this PR now. |
Description:
Add Splunk .NET docker image to the chart. Add to rotation for image updates.