Remove the networkExporter option from the helm chart #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
remove-network-explorer
branch
3 times, most recently
from
d91c500 to
04739ba
Compare
jvoravong
approved these changes
Dec 12, 2023
|
We might want to check if there are any Network Explorer metrics being tested in the v2 functional tests. LGTM overall. |
samiura
approved these changes
Dec 12, 2023
aunshc
suggested changes
Dec 12, 2023
dmitryax
force-pushed
the
remove-network-explorer
branch
from
04739ba to
53bead3
Compare
I haven't found any |
|
Looks like the tests are flaky |
Network explorer is no longer part of this helm chart and should be installed separately. See https://github.com/signalfx/splunk-otel-collector-chart/blob/main/docs/advanced-configuration.md#using-opentelemetry-ebpf-helm-chart-with-splunk-opentelemetry-collector-for-kubernetes for more details.
dmitryax
force-pushed
the
remove-network-explorer
branch
from
53bead3 to
791ac08
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network explorer is no longer part of this helm chart and should be installed separately. See https://github.com/signalfx/splunk-otel-collector-chart/blob/main/docs/advanced-configuration.md#using-opentelemetry-ebpf-helm-chart-with-splunk-opentelemetry-collector-for-kubernetes for more details.
The helm chart installation will fail if
networkExporter.enabled=trueand will print a warning if networkExporter is used in any other way