Skip to content

Commit

Permalink
remove networkExplorer option
Browse files Browse the repository at this point in the history
  • Loading branch information
atoulme committed Feb 13, 2024
1 parent c6d3962 commit c9e7ba8
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 10 deletions.
12 changes: 12 additions & 0 deletions .chloggen/removenetworkexplorer.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: networkExplorer
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: The `networkExplorer` option was deprecated in 0.88.0. It is now entirely removed.
# One or more tracking issues related to the change
issues: [1156]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
4 changes: 4 additions & 0 deletions UPGRADING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Upgrade guidelines

# 0.93.0 to 0.94.0

The `networkExplorer` option is removed.

## 0.87.0 to 0.88.0

The `networkExplorer` option is deprecated now. Please use the upstream OpenTelemetry eBPF Helm chart to collect
Expand Down
6 changes: 0 additions & 6 deletions helm-charts/splunk-otel-collector/templates/NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,3 @@ Splunk OpenTelemetry Collector is installed and configured to send data to Splun
- Some libraries may be enabled by default. For current status, see: https://github.com/open-telemetry/opentelemetry-operator#controlling-instrumentation-capabilities
- Splunk provides best-effort support for native OpenTelemetry libraries, and full support for Splunk library distributions. For used libraries, refer to the values.yaml under "operator.instrumentation.spec".
{{- end }}
{{- if and (not (eq (toString .Values.networkExplorer) "<nil>")) .Values.networkExplorer.enabled }}
{{ fail "Network explorer is not part of this helm chart anymore. Please follow https://github.com/signalfx/splunk-otel-collector-chart/blob/main/UPGRADING.md#0870-to-0880 to replace it with the upstream OpenTelemetry eBPF helm chart." }}
{{- end }}
{{- if not (eq (toString .Values.networkExplorer) "<nil>")}}
[WARNING] `networkExplorer` option is no longer supported. Please remove it from your custom values.yaml.
{{- end }}
4 changes: 0 additions & 4 deletions helm-charts/splunk-otel-collector/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1409,10 +1409,6 @@
"type": "boolean",
"deprecated": true
},
"networkExplorer": {
"deprecated": true,
"additionalProperties": true
},
"operator": {
"description": "OpenTelemetry Operator configuration. A subchart that is used to install the operator, see https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-operator/values.schema.json for more info.",
"type": "object",
Expand Down

0 comments on commit c9e7ba8

Please sign in to comment.