Skip to content

Commit

Permalink
Remove excessive istio attributes to avoid hitting the dimensions limit
Browse files Browse the repository at this point in the history
Add a new processor attributes/istio to drop excessive istio attributes and avoid running into the dimensions limit if scraping istio metrics is enabled.
  • Loading branch information
dmitryax committed May 2, 2023
1 parent a93e574 commit 5746e55
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
skipped when we use both `multilineConfig` AND `extraOperators` in values.yaml
- Enable retry mechanism in filelog receiver to avoid dropping logs on backpressure from the downstream
pipeline components [#764](https://github.com/signalfx/splunk-otel-collector-chart/pull/764)
- Drop excessive istio attributes to avoid running into the dimensions limit when scraping istio metrics is enabled [765](https://github.com/signalfx/splunk-otel-collector-chart/pull/765)

## [0.75.0] - 2023-04-17

Expand Down
23 changes: 23 additions & 0 deletions helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,26 @@ processors:
new_name: container.memory.usage
{{- end }}

{{- if or .Values.autodetect.prometheus .Values.autodetect.istio }}
# This processor is used to remove excessive istio attributes to avoid running into the dimensions limit.
# This configuration assumes single cluster istio deployment. If you run istio in multi-cluster scenarios,
# you may need to adjust this configuration.
attributes/istio:
include:
match_type: regexp
metric_names:
- istio_.*
actions:
- action: delete
key: source_cluster
- action: delete
key: destination_cluster
- action: delete
key: source_canonical_service
- action: delete
key: destination_canonical_service
{{- end }}

# By default only SAPM exporter enabled. It will be pointed to collector deployment if enabled,
# Otherwise it's pointed directly to signalfx backend based on the values provided in signalfx setting.
# These values should not be specified manually and will be set in the templates.
Expand Down Expand Up @@ -774,6 +794,9 @@ service:
processors:
- memory_limiter
- batch
{{- if or .Values.autodetect.prometheus .Values.autodetect.istio }}
- attributes/istio
{{- end }}
- resourcedetection
- resource
{{- if (and .Values.splunkPlatform.metricsEnabled .Values.environment) }}
Expand Down

0 comments on commit 5746e55

Please sign in to comment.