From 44d7cfbc0c326d74dda0ccaf4a46382eed040d5e Mon Sep 17 00:00:00 2001 From: Mateusz Rzeszutek Date: Wed, 6 Sep 2023 14:25:34 +0200 Subject: [PATCH] Update repository permissions and log message when service name is not set (#252) --- specification/configuration.md | 4 ++-- specification/repository.md | 6 ++---- specification/templates/.github/CODEOWNERS | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/specification/configuration.md b/specification/configuration.md index 108a30d..7881604 100644 --- a/specification/configuration.md +++ b/specification/configuration.md @@ -214,8 +214,8 @@ are required. name or link to relevant documentation. E.g. ```txt - service.name attribute is not set, your service is unnamed and will be difficult to identify. - set your service name using the OTEL_SERVICE_NAME environment variable. + The service.name resource attribute is not set. Your service is unnamed and will be difficult to identify. + Set your service name using the OTEL_SERVICE_NAME or OTEL_RESOURCE_ATTRIBUTES environment variable. E.g. `OTEL_SERVICE_NAME=""` ``` diff --git a/specification/repository.md b/specification/repository.md index 05e3fe4..8de0b05 100644 --- a/specification/repository.md +++ b/specification/repository.md @@ -22,12 +22,10 @@ approval is granted, GDI repositories MUST NOT cut a GA release. - MUST grant `Admin` [permission level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization) - to maintainers team + to maintainers team and the `gdi-instrumentation-admins` team - MUST grant `Write` [permission level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization) - to approvers team and the `signalfx/docs`, - `signalfx/gdi-specification-approvers` - `signalfx/gdi-specification-maintainers` teams + to approvers team and the `signalfx/gdi-docs` team - MUST NOT grant `Write`, `Maintain`, `Admin` [permission level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization) to any other team diff --git a/specification/templates/.github/CODEOWNERS b/specification/templates/.github/CODEOWNERS index 3db156f..bc73022 100644 --- a/specification/templates/.github/CODEOWNERS +++ b/specification/templates/.github/CODEOWNERS @@ -14,4 +14,4 @@ *.md @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs *.rst @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs docs/ @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs -README* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs @signalfx/gdi-specification-approvers @signalfx/gdi-specification-maintainers +README* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs