Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Send image from URL #4695

Closed
1 task done
iwikal opened this issue Dec 7, 2020 · 6 comments
Closed
1 task done

Feature: Send image from URL #4695

iwikal opened this issue Dec 7, 2020 · 6 comments

Comments

@iwikal
Copy link

iwikal commented Dec 7, 2020

  • I have searched open and closed issues for duplicates

Feature Description

I often want to share an image I found online. If I'm to share this image with Signal, I either have to download it first and attach it, or send the link and have the recipient open it in their browser. It would be nice if I could paste the link somewhere and have Signal automatically download and send it in one step.

@harshilparmar
Copy link

We can do that by dividing the image upload process into two steps.

  1. Check the attached link extension (png, jpeg)
  2. if link contains valid image format download image by js and passes it to normal upload functionality
  3. it's done
    Correct me if I am wrong !! It is my first approach after seeing this problem

@EvanHahn-Signal
Copy link
Contributor

@harshilparmar That sounds like a good first approach. Some other things to consider:

  • Do we want this to instead piggyback on our link preview functionality?
  • Are there privacy concerns here? For example, if someone pastes a link, would they expect it to be automatically downloaded by Signal?
  • Images can be served without .png or .jpg extensions. For example, https://example.com/logo could be a JPEG, even though its suffix doesn't end in .jpg. How do we want to handle this?
  • If the image is corrupted, what do we do?
  • If the image fails to download for some reason (due to network issues, for example), what should we do?
  • Are there concerns for Signal's servers? Will this dramatically increase the load such that it will be too expensive for us to run?
  • Are there client bandwidth concerns? It uses less bandwidth to send a URL versus sending an image...will that be a problem for our users?
  • If this is configurable, where does it live in the settings? How do we translate the text into all of the languages we support? How do we explain it to users?

Not saying we shouldn't do this, but this seemingly-simple feature is fairly complicated.

@iwikal
Copy link
Author

iwikal commented Jan 13, 2021

I was thinking this would be a deliberate action by the user, like a new option that appears beside 'camera' and 'album', not something that happens automatically as soon as I paste a link in the text input. I think that alleviates some of the listed concerns, such as bandwidth, privacy, extensions.

@xathon
Copy link

xathon commented Jan 14, 2021

I think the way WhatsApp does it is that when you post a direct link to an image, the link preview shows a download icon you can click to open the regular image share. That way the download stays a deliberate action but doesn't add another persistent icon to the toolbar.

@EvanHahn-Signal
Copy link
Contributor

Makes sense. We'll think about this.

@Penguin-Guru
Copy link

I'm not sure how the preview functionality actually works but that seems like the best approach to me. The only problem I imagine is if the file server is configured to remove the file after it is downloaded once. That's probably not likely in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants