Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A trailing dash/hyphen of an URL is not "hyperlinked" #11310

Closed
4 tasks done
versgui opened this issue May 17, 2021 · 3 comments
Closed
4 tasks done

A trailing dash/hyphen of an URL is not "hyperlinked" #11310

versgui opened this issue May 17, 2021 · 3 comments

Comments

@versgui
Copy link

versgui commented May 17, 2021


Bug description

When I send an URL with a trailing hyphen, this hyphen is missing in the hyperlink added by Signal on this URL.
Example of a sent message :

https://fr.ulule.com/sapins-barbus-la-bd-/

The hyperlink goes to https://fr.ulule.com/sapins-barbus-la-bd

Steps to reproduce

  • send a message, containing an URL with a trailing dash
  • the trailing dash is missing in the hyperlink

Actual result: Because the hyperlink is wrong, it could generate a 404 error when the user click on the URL
Expected result: The hyperlink should be faithful to the URL, and contain all the characters indicated

Screenshots

Screenshot_20210517-125638_Signal

Device info

Device: Samsung Galaxy S7
Android version: 8.0.0
Signal version: 5.11.3

Link to debug log

@zfreeds
Copy link

zfreeds commented May 18, 2021

The smallest text I could replicate with is A.com/ a or A.com/a/ a. The same issue happens with A.com/aa- a. The end space and character are necessary.

@stale
Copy link

stale bot commented Jan 26, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 26, 2022
@stale stale bot closed this as completed Feb 2, 2022
@gediminasel
Copy link

gediminasel commented Jun 7, 2022

Still relevant 😢 Some pages require a trailing slash to work correctly. Could someone reopen this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants