Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support is missing. #43

Open
saadi-ninjasCode opened this issue Aug 27, 2021 · 7 comments
Open

RTL support is missing. #43

saadi-ninjasCode opened this issue Aug 27, 2021 · 7 comments

Comments

@saadi-ninjasCode
Copy link
Contributor

App support RTL, but this package is not supporting RTL. As shown in the figure, The modal should be on the left side under the three dots icon but it is still on the right side.

Screenshot 2021-08-27 at 9 56 20 PM

Anyone can help in solving my issue? I want a generic solution as I am using this dropdown in multiple places

Version

  • React-Native: 64.2
  • react-native-modal-dropdown: 1.0.1
@Tonyibra
Copy link

Tonyibra commented Apr 8, 2022

updates?

@FatmaMahmoud698
Copy link

any update?

@MGEisa96
Copy link

how did you fix it ?

@saadi-ninjasCode
Copy link
Contributor Author

how did you fix it ?

I fixed it on my own. I made some changes to this library according to my need.

@FatmaMahmoud698
Copy link

@saadi-ninjasCode can you share with us your updated package?

@siemiatj
Copy link
Owner

how did you fix it ?

I fixed it on my own. I made some changes to this library according to my need.

If you would submit a PR I can merge this and release in npm.

@saadi-ninjasCode
Copy link
Contributor Author

@FatmaMahmoud698 , @MGEisa96 , I Submit a PR. If you need any help here is the PR link
#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants