Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract-socket prevent from being truly native #92

Closed
sdumetz opened this issue Jul 30, 2015 · 5 comments
Closed

Abstract-socket prevent from being truly native #92

sdumetz opened this issue Jul 30, 2015 · 5 comments

Comments

@sdumetz
Copy link

sdumetz commented Jul 30, 2015

the abstract-socket dependency is compiled. It goes against this module being truly javascript-native.

Why does it matter? I use electron and module recompilation is quite a pain in numerous cases.

While i've seen abstract sockets before, I have no idea if a pure js + native core modules implementation would be possible?

@sidorares
Copy link
Owner

No, native core does not support abstract sockets. Its currently in optional dependencies and it's still possible to use module if abstract-socket is not installed.

Usually system bus is exposed with unix socket and session bus - using abstract socket address

@ghost
Copy link

ghost commented Jan 31, 2016

is anything going to be done on this issue?

@sidorares
Copy link
Owner

No, unless abstract sockets are supported by core node ( it's relatively trivial change, Python for example have it in core networking ) but given that userland module works well and that is linux-only functionality it's very unlikely to happen. As a workaround we could include another dependency - socat binary installed locally, and pipe to socat process which would forward stdin to linux abstract socket, but I think not worth effort.

@sidorares
Copy link
Owner

actually there are some changes in libuv that might allow abstract sockets ( not expecting zero-terminated string as input ). I'll do some more research and reopen if find anything

@sidorares
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants