Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent file descriptors leaks to child processes #9413

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

smira
Copy link
Member

@smira smira commented Oct 1, 2024

See #9412

I'll keep the issue open to track upstream PR status and remove replace directives.

@smira smira added this to the v1.9 milestone Oct 1, 2024
smira added a commit to smira/talos that referenced this pull request Oct 1, 2024
See siderolabs#9413

Not sure how to turn this into a useful test.

Signed-off-by: Andrey Smirnov <[email protected]>
@smira
Copy link
Member Author

smira commented Oct 1, 2024

I used #9414 to verify fixes

See siderolabs#9412

I'll keep the issue open to track upstream PR status and remove replace
directives.

Signed-off-by: Andrey Smirnov <[email protected]>
go.mod Show resolved Hide resolved
Copy link
Member

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed after force-push

@smira
Copy link
Member Author

smira commented Oct 1, 2024

/m

@talos-bot talos-bot merged commit a341bdb into siderolabs:main Oct 1, 2024
50 checks passed
@smira smira mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backported
Development

Successfully merging this pull request may close these issues.

4 participants