Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control plane components extraArgs are non-functional #1523

Closed
Ulexus opened this issue Nov 19, 2019 · 3 comments · Fixed by #1812
Closed

Control plane components extraArgs are non-functional #1523

Ulexus opened this issue Nov 19, 2019 · 3 comments · Fixed by #1812
Assignees
@rsmitty
Milestone
v0.4

Comments

@Ulexus
Copy link
Contributor

Ulexus commented Nov 19, 2019

Setting cluster.controllerManager.extraArgs results in those args not being added to the final deploy/kube-controller-manager manifest.

This is also true for cluster.apiServer.extraArgs.
@Ulexus
Copy link
Contributor Author

Ulexus commented Nov 19, 2019

This is a bit of a quandary, though, since this may be more of a bootkube thing... so this may need to wait until the bootkube manifest customization mechanism is more formalized.

@andrewrynhard
Copy link
Member

Yeah this is something we will need in bootkube first :(

@andrewrynhard andrewrynhard added this to the v0.4 milestone Jan 2, 2020
@andrewrynhard
Copy link
Member

Research:

  • What changes will be needed in bootkube
  • Create an issue in upstream bootkube to discuss the implementation

@andrewrynhard andrewrynhard changed the title cluster.controllerManager.extraArgs appears to be non-functional Control plane components extraArgs are non-functional Jan 20, 2020
@rsmitty rsmitty self-assigned this Jan 22, 2020
rsmitty added a commit to rsmitty/talos that referenced this issue Jan 23, 2020
@rsmitty
fix: re-enable control plane flags
7dba4a4 
This PR aims to fix the ability to pass extra flags to control plane
components. This will close siderolabs#1523

Signed-off-by: Spencer Smith <[email protected]>
rsmitty added a commit to rsmitty/talos that referenced this issue Jan 23, 2020
@rsmitty
fix: re-enable control plane flags
9a65553 
This PR aims to fix the ability to pass extra flags to control plane
components. This will close siderolabs#1523

Signed-off-by: Spencer Smith <[email protected]>
@rsmitty rsmitty mentioned this issue Jan 23, 2020
Merged
rsmitty added a commit to rsmitty/talos that referenced this issue Jan 23, 2020
@rsmitty
fix: re-enable control plane flags
69191cb 
This PR aims to fix the ability to pass extra flags to control plane
components. This will close siderolabs#1523

Signed-off-by: Spencer Smith <[email protected]>
rsmitty added a commit that referenced this issue Jan 23, 2020
@rsmitty
fix: re-enable control plane flags
aabd46e 
This PR aims to fix the ability to pass extra flags to control plane
components. This will close #1523

Signed-off-by: Spencer Smith <[email protected]>
andrewrynhard pushed a commit to andrewrynhard/talos that referenced this issue Jan 27, 2020
@rsmitty @andrewrynhard
fix: re-enable control plane flags
a4a1229 
This PR aims to fix the ability to pass extra flags to control plane
components. This will close siderolabs#1523

Signed-off-by: Spencer Smith <[email protected]>
(cherry picked from commit aabd46e)
andrewrynhard pushed a commit that referenced this issue Jan 28, 2020
@rsmitty @andrewrynhard
fix: re-enable control plane flags
c2de43b 
This PR aims to fix the ability to pass extra flags to control plane
components. This will close #1523

Signed-off-by: Spencer Smith <[email protected]>
(cherry picked from commit aabd46e)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rsmitty rsmitty

Labels
None yet
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

fix: re-enable control plane flags rsmitty/talos
3 participants
@rsmitty @Ulexus @andrewrynhard