Skip to content

Commit

Permalink
fix: update the CRI sandbox image reference
Browse files Browse the repository at this point in the history
Fix the test, and update the reference.

Signed-off-by: Andrey Smirnov <[email protected]>
  • Loading branch information
smira committed Oct 28, 2024
1 parent cec290b commit c755b6d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion internal/integration/api/containers.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,17 @@ func (suite *ContainersSuite) TestSandboxImage() {
for _, message := range resp.GetMessages() {
suite.Assert().NotEmpty(message.GetContainers())

matched := false

for _, ctr := range message.GetContainers() {
if ctr.PodId == "" {
if ctr.PodId == ctr.Id {
suite.Assert().Equal(images.DefaultSandboxImage, ctr.Image)

matched = true
}
}

suite.Assert().True(matched, "no pods found, node %s", node)
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/images/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type Versions struct {
// DefaultSandboxImage is defined as a constant in cri package of containerd, and it's not exported.
//
// The integration test verifies that our constant is accurate.
const DefaultSandboxImage = "registry.k8s.io/pause:3.9"
const DefaultSandboxImage = "registry.k8s.io/pause:3.10"

// List returns default image versions.
func List(config config.Config) Versions {
Expand Down

0 comments on commit c755b6d

Please sign in to comment.