fix: propagate the headers before the message #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
approved these changes
Oct 23, 2024
Always propagate the headers via the proxy first, then attempt to receive the message. This fixes the issue where a connection sends the headers before the message, e.g., in the reverse GRPC tunnel implementation here: https://github.com/jhump/grpctunnel/blob/56803ed3149f539b95950ef306c01befa705ebe5/handler.go#L160-L164 Add new tests for the reverse tunnel. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
reverse-tunnel-headers-fix
branch
from
3b345bd
to
80677e0
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always propagate the headers via the proxy first, then attempt to receive the message. This fixes the issue where a connection sends the headers before the message, e.g., in the reverse GRPC tunnel implementation here: https://github.com/jhump/grpctunnel/blob/56803ed3149f539b95950ef306c01befa705ebe5/handler.go#L160-L164
Add new tests for the reverse tunnel.