Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable WARN github token not found in output #158

Open
itsuryev opened this issue Oct 9, 2017 · 3 comments
Open

Disable WARN github token not found in output #158

itsuryev opened this issue Oct 9, 2017 · 3 comments

Comments

@itsuryev
Copy link

itsuryev commented Oct 9, 2017

Do you want to request a feature or report a bug?
Bug I guess

What is the current behavior?
Right now I get following output:

 WARN  github token not found

    You are missing out on some cool features.
    Read more here: https://github.com/siddharthkp/bundlesize#2-build-status
   

 PASS  ../resources/dist/static/js/app.37cef5f1.js: 640.49KB < maxSize 670KB gzip 

If the current behavior is a bug, please provide the steps to reproduce.
Do not set github token, run bundlesize on CI

What is the expected behavior?
I use gitlab, so warning above simply adds noise to ouput. I would like to be able to suppress it somehow

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information.

  • node version
  • npm version
  • Operating system
  • bundlesize version
  • CI you are using
@itsuryev itsuryev changed the title Disable WARN github token not found Disable WARN github token not found in output Oct 9, 2017
@siddharthkp
Copy link
Owner

Ah, good catch! I hadn't thought of that.

I wouldn't want to remove it completely because it is a pretty cool feature that I want people to use. But would definitely disable it for non-github folks.

I wonder if we can add another key in ci-env to pass the host/source and work with that.

Would you want to work on this?

@armandabric
Copy link

armandabric commented Aug 13, 2019

I also run into this and I'm using Github actions as a CI. I didn't need the status check on my PR as already have the one from my CI job.

I see in one of you PR that you disable it. Could we have a release of the library ? 😄

@siddharthkp
Copy link
Owner

siddharthkp commented Aug 13, 2019

@Spy-Seth Hey! I have removed this on the beta channel.

If you're not using comparison with master, you can start using that: #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants