You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi archislav,
thanks for reporting. I will take a closer look into this issue next week.
We haven't tried out guice interceptors yet because for our internal projects we mostly use CDI.
Our guice module is based on the fx-guice project. Do you know if interceptors are working there?
Hi, Lestard. I've checked fx-guice - it works fine with interceptors (It also provides FxApplicationThread annotation for executing method in JavaFX thread).
de.saxsys.mvvmfx.internal.viewloader.ViewLoaderReflectionUtils::getViewModelField tries to find @InjectViewModel only in current viewType, but in case of interceptors Guice creates subclass of viewType - that why it can't find such field.
With PR #336 I've now changed the getViewModelFields method so that it searches in the whole class hierarchy to find the correct field. A test case with a guice interceptor now runs green.
A snapshot version with this bugfix will be automatically pushed to maven central so you can test it. Use version 1.4.1-SNAPSHOT.
We are planing to release the final 1.4.1. version next week.
For example, we have
and guice module with interceptor
ViewLoaderReflectionUtils::getViewModelField returns Optional.empty in this case.
The text was updated successfully, but these errors were encountered: