Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Kotlin Android extensions from Wildcard import rule #16

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

kunny
Copy link
Contributor

@kunny kunny commented Oct 11, 2016

According to codestyle, it allows to have wildcard imports for Kotlin Android Extensions:

<JetCodeStyleSettings>
    <option name="PACKAGES_TO_USE_STAR_IMPORTS">
      <value>
        <package name="kotlinx.android.synthetic" withSubpackages="true" static="false" />
      </value>
    </option>
    <option name="NAME_COUNT_TO_USE_STAR_IMPORT" value="2147483647" />
    <option name="NAME_COUNT_TO_USE_STAR_IMPORT_FOR_MEMBERS" value="2147483647" />
  </JetCodeStyleSettings>

This PR excludes imports of kotlin android extensions from being detected as 'Wildcard import'.

Plus, includes a fix for minor typo issue in pom.xml

@shyiko
Copy link
Collaborator

shyiko commented Oct 11, 2016

@kunny Thank you 👍

@shyiko shyiko merged commit cc4f1b7 into pinterest:master Oct 11, 2016
@shyiko
Copy link
Collaborator

shyiko commented Oct 11, 2016

@kunny 0.2.2 released (Maven Central sync might take up to 2 hours).

@kunny
Copy link
Contributor Author

kunny commented Oct 12, 2016

Whoa, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants