Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semicolon at end of package declaration not reported, different error instead #59

Closed
gabrielittner opened this issue Jun 19, 2017 · 1 comment

Comments

@gabrielittner
Copy link
Contributor

For

package com.example.foo;

data class Foo(val bar: String)

I get this: com/example/foo/Foo.kt:1:25: Missing spacing after ";" and ktlintFormat will add that space. Shouldn't the error be that there is a semicolon?

@shyiko shyiko closed this as completed in 29effae Jun 19, 2017
@shyiko
Copy link
Collaborator

shyiko commented Jun 19, 2017

Thank you, @gabrielittner! Fixed in 0.8.3 (Maven Central sync might take up to 25 minutes).

shyiko added a commit that referenced this issue Jul 24, 2017
* 'master' of github.com:shyiko/ktlint:
  CI with JDK 8
  Upgrade to kotlin 1.1.3-2
  🤦
  allow for named lambdas
  Fix misleading indent lint error message
  Added 0.8.3 release note(s)
  Fixed #55 - If `setValue` is declared as an extension method ktlint thinks its unused
  Fixed #59 - Semicolon at end of package declaration not reported, different error instead
  Fix regression for spacing around else keyword
  Implement spacing after setter and getter
  Add test cases for spacing after setter and getter
  Added 0.8.2 release note
  Fixed #54 - if `getValue` is declared as an extension method ktlint thinks its unused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants