Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: downgrade fatal crash error for <Link> component #596

Merged
merged 6 commits into from
Sep 12, 2024
Merged

feat: downgrade fatal crash error for <Link> component #596

merged 6 commits into from
Sep 12, 2024

Conversation

evenchange4
Copy link
Contributor

@evenchange4 evenchange4 commented Aug 30, 2024 •
edited
Loading

Improve Page Stability by Handling Fatal Crashes 致命錯誤降級處理

Development Mode:

On fatal errors, immediately show the "Internal Application Error" page.

Production Mode: Downgrade fatal error

  1. console.error without causing an immediate page crash.
  2. Only after user clicks <Link>, page re-render and display the "Internal Application Error" page.

Large GIF (1034x742)

@evenchange4 evenchange4 changed the title refactor: downgrade Link error, throw after click to avoid fatal page… refactor: downgrade Link error, throw after click to avoid fatal crash Aug 30, 2024
liximomo
liximomo requested changes Aug 30, 2024
View reviewed changes
packages/router-react/src/Link.tsx Outdated Show resolved Hide resolved
@evenchange4 evenchange4 changed the title refactor: downgrade Link error, throw after click to avoid fatal crash refactor: downgrade Prod Link error, throw after click to avoid fatal page crash Sep 6, 2024
@evenchange4 evenchange4 changed the title refactor: downgrade Prod Link error, throw after click to avoid fatal page crash [WIP] refactor: downgrade Prod Link error, throw after click to avoid fatal page crash Sep 9, 2024
@evenchange4 evenchange4 changed the title [WIP] refactor: downgrade Prod Link error, throw after click to avoid fatal page crash feat: downgrade fatal crash error for <Link> Sep 9, 2024
@evenchange4 evenchange4 marked this pull request as ready for review September 9, 2024 04:39
@evenchange4 evenchange4 changed the title feat: downgrade fatal crash error for <Link> feat: downgrade fatal crash error for <Link> component Sep 9, 2024
@evenchange4 evenchange4 changed the title feat: downgrade fatal crash error for <Link> component [WIP] feat: downgrade fatal crash error for <Link> component Sep 10, 2024
@evenchange4 evenchange4 changed the title [WIP] feat: downgrade fatal crash error for <Link> component feat: downgrade fatal crash error for <Link> component Sep 11, 2024
liximomo
liximomo approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@liximomo liximomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liximomo liximomo merged commit 1205fc5 into shuvijs:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liximomo liximomo liximomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evenchange4 @liximomo