Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Don't pull in axum 0.6 when trying shuttle-axum feature 'axum-0-7' #1474

Closed
1 task done
TClasen-Foxit opened this issue Dec 7, 2023 · 2 comments
Closed
1 task done
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features

Comments

@TClasen-Foxit
Copy link

Describe the improvement

updating a project to use axum 0.7, using shuttle-axum = { version = "0.35.0", default-features = false, features = ["axum-0-7"], optional = false }, unfortunately still adds axum 0.6 through the transitive shuttle-runtime and its own shuttle-common dependency. I couldn't find a way to disable this by disabling default and optional features on common/runtime.

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@TClasen-Foxit TClasen-Foxit added S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features labels Dec 7, 2023
@TClasen-Foxit
Copy link
Author

I looked into it and it looks like this cannot be avoided at the moment as axum seems to be a necessary dependency of shuttle-common itself. I guess this will be fixed once shuttle has been itself updated to axum 0.7

@jonaro00
Copy link
Member

jonaro00 commented Dec 7, 2023

@TClasen-Foxit That's correct. Thanks for raising the concern.
Even after we upgrade to 0.7 we would still need hyperium/tonic#1583 (and maybe some more). A waiting game :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features
Projects
None yet
Development

No branches or pull requests

2 participants