Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apparently peerDeps is the way #4

Merged
merged 2 commits into from
May 28, 2024
Merged

Apparently peerDeps is the way #4

merged 2 commits into from
May 28, 2024

Conversation

huntharo
Copy link
Contributor

@huntharo huntharo commented May 28, 2024 •
edited
Loading

  • The prior approach worked with npm but not with yarn1

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

📊 Node.js Code Coverage Report

File Lines Lines Hit / Found Uncovered Lines Branches
src/kinesis-background-writer.ts ✅ 100.0% 137 / 137 0 100.0%
src/kinesis-retrier.ts ✅ 94.6% 210 / 222 12 77.8%
Overall ✅ 96.7% 347 / 359 12 82.8%

@huntharo huntharo merged commit 23b944f into main May 28, 2024
3 checks passed
@huntharo huntharo deleted the fix-deps branch May 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huntharo