Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rediska_Serializer_Adapter_Json::unserialize does not respect decoding options. #94

Open
iwsfg opened this issue May 8, 2015 · 0 comments

Comments

@iwsfg
Copy link

iwsfg commented May 8, 2015

It always retrieving json decoded using StdClass-es, even if options says it should be associative arrays (and it should be by default). Line 90 should be changed from

$decodedValue = json_decode($value);

to

$decodedValue = json_decode($value, $this->_options['decodetype'], $this->_options['decodedepth']);

also const DECODE_TYPE_OBJECT is unusued and probably should not be defined.

And I think I must point out that without changing default behavior back to objects it will be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant