fix: clean-up the rate sequence goroutines to avoid leaking #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated on Ticker.Stop:
This sole fact prevents the goroutine from exiting, and in result, causes a leak that is especially problematic when the project is used through an API and not a CLI.
This particular bug is directly affecting the Telegraf's Internet Speed Input Plugin, so this fix is only resolving the part relevant to the plugin.
There are two more occurrences of this pattern:
speedtest-go/speedtest/data_manager.go
Line 103 in 320b5b7
speedtest-go/speedtest/data_manager.go
Line 114 in 320b5b7
Unfortunately, fixing them would probably require an API change, so I'm purposefully leaving that to the maintainers of this project.