feat: add download, upload, ping tests duration #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @bluemanos, should we include the time consuming for fetching user infomation and servers? |
|
@r3inbowari I can add it, no problem. Indeed these operations also are taking some time, not directly in testing the connection, but in preparation for testing. My intention was to just get information on how much time the testing took. |
|
Hi, @bluemanos, I left some comments, Thank you! |
|
@r3inbowari where are the comments? I think you start a review, but in the end, did not send them. It happens :D |
r3inbowari
reviewed
Apr 12, 2023
Sorry! |
r3inbowari
reviewed
Apr 13, 2023
r3inbowari
reviewed
Jun 4, 2023
|
@bluemanos Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I added a ping, download and upload duration. Plus one common function to measure all the things at once (one by one of course).