Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openLinksInNewWindow should not apply to internal anchor links (e.g. TOC links) #457

Closed
KirkMunro opened this issue Nov 8, 2017 · 4 comments
Assignees
Labels
enhancement PR: request-changes This PR needs additional changes

Comments

@KirkMunro
Copy link

Right now if you use openLinksInNewWindow, all links get updated to open in a new window, including internal anchor links. This is not desirable. Please consider changing the default behavior such that internal anchor links are ignored/skipped by the openLinksInNewWindow setting. Thanks!

@tivie tivie self-assigned this Nov 9, 2017
@tivie tivie added enhancement PR: request-changes This PR needs additional changes labels Nov 9, 2017
@tivie
Copy link
Member

tivie commented Nov 9, 2017

Although there isn't a perfect solution for this issue (since that would require showdown to be aware of URL context), showdown can disable target="__blank" for relative urls that start with a #.

@KirkMunro
Copy link
Author

That's what I was looking for. I think that would be a nice improvement for openLinksInNewWindow.

@tivie
Copy link
Member

tivie commented Nov 11, 2017

Should be fixed now (version 1.8.2)


As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money. Currently, we're looking to improve showdown with automated tests in all browsers and a proper domain and webpage. 500$ should be enough to to keep showdown testing framework running for a year or two.

If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated.

@tivie tivie closed this as completed in 11936ec Nov 11, 2017
@FreeTrade
Copy link

@tivie

showdown can disable target="__blank" for relative urls that start with a #.

This does not seem to apply to ghMentionsLink as at version 1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PR: request-changes This PR needs additional changes
Projects
None yet
Development

No branches or pull requests

3 participants