Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeHtml broken/hangs when called with string containing html tags (v1.7.0) #393

Closed
andistuder opened this issue Jun 1, 2017 · 2 comments
Assignees
Labels

Comments

@andistuder
Copy link

When calling makeHtml with a string containing html markup, the converter seems to hang.

Example:

const showdown = require('showdown');
const converter = new showdown.Converter();
let html = converter.makeHtml('<p>My<p>');

This issue seems to have been introduced with v1.7.0.

Anyone experiencing similar issues?

@tivie tivie self-assigned this Jun 1, 2017
@tivie tivie added the bug label Jun 1, 2017
@tivie
Copy link
Member

tivie commented Jun 1, 2017

verified. Showdown hangs with malformed HTML. The bug was introduced with the new HTML parser.
I will publish a hotfix as soon as possible


We're currently looking to improve showdown with automated tests in all browsers and a proper domain and webpage. If you like our work, please donate!! Your contribution will be greatly appreciated.

https://www.paypal.me/tiviesantos

@tivie tivie closed this as completed in 6566c72 Jun 2, 2017
@tivie
Copy link
Member

tivie commented Jun 2, 2017

should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants