Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openLinksInNewWindow breaks _em_ markup #379

Closed
andistuder opened this issue Apr 25, 2017 · 5 comments
Closed

openLinksInNewWindow breaks _em_ markup #379

andistuder opened this issue Apr 25, 2017 · 5 comments
Assignees
Labels

Comments

@andistuder
Copy link

andistuder commented Apr 25, 2017

When running the converter with openLinksInNewWindow set to true, it seems to break the conversion of the _underscore_ => <em>underscore</em> markup.

example string:
My [link](http://example.com) is _important_

when I convert it with openLinksInNewWindow set false, I receive (as expected):
<p>My <a href="http://example.com">link</a> is <em>important</em></p>

when I convert it with openLinksInNewWindow set true, I receive:
<p>My <a href="http://example.com">link</a> is _important_</p>
the word important no longer wrapped with the em tag.

Conversion of *star* => <em>star</em> works fine.

@tivie tivie self-assigned this Apr 25, 2017
@tivie tivie added the bug label Apr 25, 2017
@tivie
Copy link
Member

tivie commented Apr 25, 2017

Verified

@tivie
Copy link
Member

tivie commented Apr 25, 2017

should be fixed now

@andistuder
Copy link
Author

Much appreciated @tivie! When are you planning to merge this to master?

@tivie
Copy link
Member

tivie commented Apr 26, 2017

Soon. I'm planning the next release but wanted to merge #358 this PR that is dependent on creating a couple of tests. As soon as #358 is merged, a new showdown release will be published.

@tivie tivie closed this as completed in 813f832 Jun 1, 2017
@andistuder
Copy link
Author

Thanks for the quick fix @tivie - I can confirm that works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants