Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'simpleLineBreaks' doesn't work when a line ends with a Chinese character #318

Closed
chaoshxxu opened this issue Dec 23, 2016 · 2 comments
Closed

'simpleLineBreaks' doesn't work when a line ends with a Chinese character #318

chaoshxxu opened this issue Dec 23, 2016 · 2 comments
Assignees
@tivie
Labels
bug

Comments

@chaoshxxu
Copy link

chaoshxxu commented Dec 23, 2016 •
edited
Loading 

foo烫
bar

foo
bar

Despite setting 'simpleLineBreaks' to true, the fragment above is rendered to:

<p>foo烫
bar</p>
<p>foo<br>
bar</p>

This issue can be reproduced in v1.5.4, while OK in v1.5.1
@tivie tivie self-assigned this Dec 23, 2016
@tivie tivie added the bug label Dec 23, 2016
@tivie
Copy link
Member

tivie commented Dec 23, 2016 •
edited
Loading

version 1.5.1 had a bug with simpleLineBreaks in lists (see #316 )
The regex was changed to only add line breaks in word boundaries.

Edit: It seems javascript \b does not recognise anything other that ASCII characters as, well "word characters" which is idiotic.

@tivie
Copy link
Member

tivie commented Jan 6, 2017 •
edited
Loading

Related to #323
Should be fixed in latest develop

@tivie tivie mentioned this issue Jan 6, 2017
Closed
@tivie tivie closed this as completed in b1c458a Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tivie tivie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaoshxxu @tivie