Enable Github code blocks inside block quotes. #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason githubCodeBlock is not called inside blockGamut is because it needs to be parsed and hashed before parsing linkDefinitions. |
|
@thanks for your contribution. I've merged it into develop branch |
This was referenced Jan 23, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including test. Similar to how it is done for lists. Looks good in my tests (already using that code).
I also wondered whether the call to
showdown.subParser('githubCodeBlocks')should be better part of theblockGamutparser as it seems to make sense whenever a block is processed. But I am not deep enough into the showdown code to see the possible side effects.