Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

[Feature] Add instrumentations code to all HTTP routes #695

Open
magicoder10 opened this issue Apr 25, 2020 · 2 comments
Open

[Feature] Add instrumentations code to all HTTP routes #695

magicoder10 opened this issue Apr 25, 2020 · 2 comments
Assignees
@Ashakibp
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
As soon as possible

Comments

@magicoder10
Copy link
Member

magicoder10 commented Apr 25, 2020 •
edited
Loading

What is the problem?
There is no measurements on how many users tried to sign in to the app using different oauth account providers.

Your solution
Add instrumentation code to all HTTP routes in order to bring observability to the team about service usage.
@magicoder10 magicoder10 added the enhancement New feature or request label Apr 25, 2020
@magicoder10 magicoder10 added this to the 04/25 - 05/01 milestone Apr 25, 2020
@lucifercr07
Copy link
Contributor

@byliuyang Please assign this to me

@magicoder10 magicoder10 assigned alldroll and unassigned lucifercr07 and alldroll May 1, 2020
@magicoder10 magicoder10 added the good first issue Good for newcomers label Jun 15, 2020
@arberiii
Copy link
Member

arberiii commented Jul 6, 2020

HTTP routes that don't have instrumentations are sign-in routes, file serving, and directory serving(swagger). Should we add instrumentation to those or close the issue?

@magicoder10 magicoder10 removed this from the 06/29 - 07/05 milestone Jul 6, 2020
@magicoder10 magicoder10 added this to the 07/06 - 07/12 milestone Jul 6, 2020
@Ashakibp Ashakibp mentioned this issue Aug 22, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ashakibp Ashakibp

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
As soon as possible
Development

No branches or pull requests
5 participants
@alldroll @magicoder10 @arberiii @lucifercr07 @Ashakibp