Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter from removeResizeListener invocation #1957

Closed
wants to merge 1 commit into from
Closed

Remove unused parameter from removeResizeListener invocation #1957

wants to merge 1 commit into from

Conversation

DanielRuf
Copy link
Contributor

1. Why is this change necessary?

removeResizeListener accepts only one parameter so the second parameter (overloading) is not needed.

2. What does this change do, exactly?

Remove the unused parameter in the removeResizeListener invocation.

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@shopwareBot
Copy link

Hey @DanielRuf ,

you have changed here a line of the Chart.js library we use. Please make the change instead in their repository

@DanielRuf
Copy link
Contributor Author

Mh, it may be better to not track vendor files (if they should not be changed) at all and use composer-patches and patch-package (Yarn, npm, ...) to patch issues in them ("do not edit vendor files").

@DanielRuf
Copy link
Contributor Author

See chartjs/Chart.js#5970

@DanielRuf DanielRuf deleted the fix/remove-unused-parameter branch March 17, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants