-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Copy func #123
Merged
Merged
Add Copy func #123
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
01609a8
Add Copy func
9ad2495
Merge branch 'master' into master
habuvo 0e940a3
Update decimal.go
habuvo 7c3409c
Update decimal.go
habuvo d68bc16
Update decimal.go
habuvo 80a623d
Update decimal.go
habuvo f74a6c0
Update decimal.go
habuvo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1553,7 +1553,7 @@ func (d Decimal) Sin() Decimal { | |
sign = !sign | ||
j -= 4 | ||
} | ||
z := d.Sub(y.Mul(PI4A)).Sub(y.Mul(PI4B)).Sub(y.Mul(PI4C)) // Extended precision modular arithmetic | ||
z := d.Sub(y.Mul(PI4A)).Sub(y.Mul(PI4B)).Sub(y.Mul(PI4C)) // Extended precision modular arithmetic | ||
zz := z.Mul(z) | ||
|
||
if j == 1 || j == 2 { | ||
|
@@ -1640,7 +1640,6 @@ var _tanQ = [...]Decimal{ | |
|
||
// Tan returns the tangent of the radian argument x. | ||
func (d Decimal) Tan() Decimal { | ||
|
||
PI4A := NewFromFloat(7.85398125648498535156e-1) // 0x3fe921fb40000000, Pi/4 split into three parts | ||
PI4B := NewFromFloat(3.77489470793079817668e-8) // 0x3e64442d00000000, | ||
PI4C := NewFromFloat(2.69515142907905952645e-15) // 0x3ce8469898cc5170, | ||
|
@@ -1684,3 +1683,15 @@ func (d Decimal) Tan() Decimal { | |
} | ||
return y | ||
} | ||
|
||
// Copy makes instance of d with same value and different pointer. | ||
// | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nitpick: I think this line is unnecessary :D There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree |
||
func (d Decimal) Copy() Decimal { | ||
d.ensureInitialized() | ||
return Decimal{ | ||
value: &(*d.value), | ||
exp: d.exp, | ||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this line? If this is gofmt issue, I will address this in separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I trying to revert it right now