Fix CSS class for a product's disabled button #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gabrielmaldi
force-pushed
the
fix-disabled-button-class
branch
from
025911b to
399594c
Compare
gabrielmaldi
force-pushed
the
fix-disabled-button-class
branch
from
399594c to
8b0eb79
Compare
melissaluu
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
👋 Hi @gabrielmaldi - thanks so much for fixing this and contributing to the library! This looks great 🎉
I'll merge it into master and it will be part of the next release 😄
|
My pleasure, @melissaluu 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a product's button is disabled (e.g. no stock), it's rendered with
undefinedas class:This patch fixes this by using the intended default class
shopify-buy__btn-disabled: