refactor: dont return a promise when opening a dialog #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Calling
modal.open()
returned a Promise ofDialogRef
. The async operation is not required and exists due to legacy angular implementation of dynamic components.modal.open()
now returns theDialogRef
instance and NOT thePromise
.You need to refactor your codebase to accomodate this change, this is a big change
and it is required to remove the complexity working with
DialogRef
.Plugin authoers:
Maybe
type does not exists anymore.If you retuned the dialog instance from your
Modal
implementations there is not much to refactor other then types here and there.If you return
Promise
ofDialogRef
you will have to refactor your code.