Refactor RTL #141
Merged
Refactor RTL #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update ngrid
fix .pbl-ngrid-row-visually-hidden min-height being overridden when using pbl-ngrid-spacing mixin fix pbl-ngrid-theme cell rtl border and positions fix pbl-ngrid-spacing rtl paddings fix drag rtl position and style (resizer handler) fix header context menu rtl position expose grid directionality use grid's dir in column resize and meta-rows' horizontal scroll calculations
add dir to DynamicColumnWidthLogic
use dir from grid in drag plugin before drag starts use dir from grid in overlay-panel fix meta rows horizontal scroll in rtl
shlomiassaf
added a commit
that referenced
this pull request
Dec 3, 2020
This commit is a hard copy of [#141](https://github.com/shlomiassaf/ngrid/pull/141/files) which was done on master (v2) and is almost imposible to merge into v3 branch due to the amount of changes Thanks @ronnetzer
shlomiassaf
added a commit
that referenced
this pull request
Dec 3, 2020
This commit is a hard copy of [#141](https://github.com/shlomiassaf/ngrid/pull/141/files) which was done on master (v2) and is almost imposible to merge into v3 branch due to the amount of changes Thanks @ronnetzer
shlomiassaf
added a commit
that referenced
this pull request
Dec 3, 2020
This commit is a hard copy of [#141](https://github.com/shlomiassaf/ngrid/pull/141/files) which was done on master (v2) and is almost imposible to merge into v3 branch due to the amount of changes Thanks @ronnetzer
shlomiassaf
added a commit
that referenced
this pull request
Dec 3, 2020
This commit is a hard copy of [#141](https://github.com/shlomiassaf/ngrid/pull/141/files) which was done on master (v2) and is almost imposible to merge into v3 branch due to the amount of changes Thanks @ronnetzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 main things were done in this PR:
fixes #129
fixes #130