Skip to content

Commit

Permalink
fix: non ESM module bundlers (webpack1) can't load plugins
Browse files Browse the repository at this point in the history
Closes #244
  • Loading branch information
Shlomi Assaf (shlassaf) committed Nov 8, 2016
1 parent 3884dc5 commit ef35c80
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 1 deletion.
15 changes: 15 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,21 @@
const path = require('path');
const fs = require('fs');
const del = require('del');
const gulp = require('gulp');
require('require-dir')('./gulp');
const runSequence = require('run-sequence');
const config = require('./gulp/config');

const ESM_PLUGINS_PATH = 'dist/plugins';
gulp.task('copyPluginsDummyPackageJson', (done) => {
const absPath = path.join(__dirname, ESM_PLUGINS_PATH);
const dirs = fs.readdirSync(absPath);
dirs.forEach( dir => {
const data = fs.readFileSync(path.join(config.PATHS.pluginDir, dir, 'package.json'));
fs.writeFileSync(path.join(__dirname, ESM_PLUGINS_PATH, dir, 'package.json'), data);
});
done();
});

const distPluginPath = { from: 'dist/esm/plugins/**/*', to: 'dist/plugins' };
gulp.task('copyDistPlugins', () => {
Expand All @@ -19,6 +33,7 @@ gulp.task('release', (done) => {
['clean:dist', 'clean:tmp'],
['copyReleaseAssets', 'bundle'],
['extractPlugins','createPackageJson'],
['copyPluginsDummyPackageJson'],
done
);
});
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "angular2-modal",
"description": "Angular2 Modal (dialog) window.",
"version": "2.0.1",
"version": "2.0.2",
"repository": {
"type": "git",
"url": "https://github.com/shlomiassaf/angular2-modal.git"
Expand Down
7 changes: 7 additions & 0 deletions src/angular2-modal/plugins/bootstrap/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "angular2-modal-bootstrap-plugin",
"version": "2.0.1",
"main": "../../bundles/angular2-modal.bootstrap.umd.js",
"module": "index.js",
"typings": "index.d.ts"
}
7 changes: 7 additions & 0 deletions src/angular2-modal/plugins/js-native/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "angular2-modal-js-native-plugin",
"version": "2.0.1",
"main": "../../bundles/angular2-modal.js-native.umd.js",
"module": "index.js",
"typings": "index.d.ts"
}
7 changes: 7 additions & 0 deletions src/angular2-modal/plugins/vex/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "angular2-modal-vex-plugin",
"version": "2.0.1",
"main": "../../bundles/angular2-modal.vex.umd.js",
"module": "index.js",
"typings": "index.d.ts"
}

0 comments on commit ef35c80

Please sign in to comment.