Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix columns order in unique_short_code_plus_domain index in MSSQL #2287

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 25, 2024

Close #2285

Fix the columns order in unique_short_code_plus_domain index in Microsoft SQL.

The columns were in the wrong order due to Version20230130090946.php

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@4e8f3f7). Learn more about missing BASE report.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2287   +/-   ##
==========================================
  Coverage           ?   93.70%           
  Complexity         ?     1658           
==========================================
  Files              ?      275           
  Lines              ?     5780           
  Branches           ?        0           
==========================================
  Hits               ?     5416           
  Misses             ?      364           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 67abe21 into shlinkio:develop Nov 25, 2024
31 checks passed
@acelaya acelaya deleted the feature/ms-index-fix branch November 25, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index on short code does not work if domain is null.
1 participant