Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mountable data dir #1969

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 3, 2024

Closes #1967
Closes #1968

This PR ensures the data dir can be mounted with an empty dir when using the docker image, in case it is required to make the filesystem read-only, like when using kubernetes' readOnlyRootFilesystem.

In order to do that, two actions have been performed:

  1. Move migrations inside module/Core directory.
  2. Update docker entrypoint script to create the data subdirectories if they don't exist. This reduces the impact in other contexts.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62b54ce) 96.90% compared to head (e7b876f) 96.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1969   +/-   ##
==========================================
  Coverage      96.90%   96.90%           
  Complexity      1344     1344           
==========================================
  Files            247      247           
  Lines           4657     4657           
==========================================
  Hits            4513     4513           
  Misses           144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onedr0p
Copy link

onedr0p commented Jan 3, 2024

Once you have a image for testing I can give it a shot!

@acelaya acelaya merged commit f9c9b3d into shlinkio:develop Jan 4, 2024
33 checks passed
@acelaya acelaya deleted the feature/mountable-data-dir branch January 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants