Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow redis credentials to be URL-decoded #1927

Closed
acelaya opened this issue Nov 23, 2023 · 0 comments · Fixed by #1928
Closed

Allow redis credentials to be URL-decoded #1927

acelaya opened this issue Nov 23, 2023 · 0 comments · Fixed by #1928
Labels
enhancement
Milestone
3.7.0

Comments

@acelaya
Copy link
Member

acelaya commented Nov 23, 2023

When redis servers contain credentials that have URL-reserved characters, it is not possible to pass them un-encoded, as the URI parsing fails.

However, passing them URL-encoded makes them be passed verbatim to the connection object, making it fail.

Add an option to allow users to decide if credentials should be URL-decoded before passing them to the connection object.

Relates to shlinkio/shlink-common#133
@acelaya acelaya added this to the 3.7.0 milestone Nov 23, 2023
@acelaya acelaya added this to Shlink Nov 23, 2023
@acelaya acelaya moved this to In Progress in Shlink Nov 23, 2023
@acelaya acelaya moved this from In Progress to In review in Shlink Nov 23, 2023
@acelaya acelaya mentioned this issue Nov 23, 2023
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Shlink
Archived in project
Milestone
3.7.0
Development

Successfully merging a pull request may close this issue.

Allow redis credentials be URL-decoded before passing them to connection acelaya-forks/shlink
1 participant
@acelaya