From 19a01870e713e4e9e5dc6454d30ff5b737ee48b6 Mon Sep 17 00:00:00 2001
From: Shivam Mathur <shivam_jpr@hotmail.com>
Date: Thu, 9 Sep 2021 07:08:12 +0530
Subject: [PATCH] Refactor config.test.ts

---
 __tests__/config.test.ts | 62 +++++++++-------------------------------
 1 file changed, 14 insertions(+), 48 deletions(-)

diff --git a/__tests__/config.test.ts b/__tests__/config.test.ts
index f17067e96..24ba9e955 100644
--- a/__tests__/config.test.ts
+++ b/__tests__/config.test.ts
@@ -1,52 +1,18 @@
 import * as config from '../src/config';
 
 describe('Config tests', () => {
-  it('checking addINIValuesOnWindows', async () => {
-    let win32: string = await config.addINIValues(
-      'post_max_size=256M, short_open_tag=On, date.timezone=Asia/Kolkata',
-      'win32'
-    );
-    expect(win32).toContain(
-      'Add-Content "$php_dir\\php.ini" "post_max_size=256M\nshort_open_tag=On\ndate.timezone=Asia/Kolkata"'
-    );
-
-    win32 = await config.addINIValues(
-      'post_max_size=256M, short_open_tag=On, date.timezone=Asia/Kolkata',
-      'openbsd'
-    );
-    expect(win32).toContain('Platform openbsd is not supported');
-  });
-
-  it('checking addINIValuesOnLinux', async () => {
-    let linux: string = await config.addINIValues(
-      'post_max_size=256M, short_open_tag=On, date.timezone=Asia/Kolkata',
-      'linux',
-      true
-    );
-    expect(linux).toContain(
-      'echo "post_max_size=256M\nshort_open_tag=On\ndate.timezone=Asia/Kolkata" | sudo tee -a "${pecl_file:-${ini_file[@]}}"'
-    );
-
-    linux = await config.addINIValues(
-      'post_max_size=256M, short_open_tag=On, date.timezone=Asia/Kolkata',
-      'openbsd'
-    );
-    expect(linux).toContain('Platform openbsd is not supported');
-  });
-
-  it('checking addINIValuesOnDarwin', async () => {
-    let darwin: string = await config.addINIValues(
-      'post_max_size=256M, short_open_tag=On, date.timezone=Asia/Kolkata',
-      'darwin'
-    );
-    expect(darwin).toContain(
-      'echo "post_max_size=256M\nshort_open_tag=On\ndate.timezone=Asia/Kolkata" | sudo tee -a "${pecl_file:-${ini_file[@]}}"'
-    );
-
-    darwin = await config.addINIValues(
-      'post_max_size=256M, short_open_tag=On, date.timezone=Asia/Kolkata',
-      'openbsd'
-    );
-    expect(darwin).toContain('Platform openbsd is not supported');
-  });
+  it.each`
+    ini_values    | os_version   | output
+    ${'a=b, c=d'} | ${'win32'}   | ${'Add-Content "$php_dir\\php.ini" "a=b\nc=d"'}
+    ${'a=b, c=d'} | ${'linux'}   | ${'echo "a=b\nc=d" | sudo tee -a "${pecl_file:-${ini_file[@]}}"'}
+    ${'a=b, c=d'} | ${'darwin'}  | ${'echo "a=b\nc=d" | sudo tee -a "${pecl_file:-${ini_file[@]}}"'}
+    ${'a=b, c=d'} | ${'openbsd'} | ${'Platform openbsd is not supported'}
+  `(
+    'checking addINIValues on $os_version',
+    async ({ini_values, os_version, output}) => {
+      expect(await config.addINIValues(ini_values, os_version)).toContain(
+        output
+      );
+    }
+  );
 });