-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type definitions for riscv64 FreeBSD #1652
base: master
Are you sure you want to change the base?
Conversation
This makes mktypes.sh succeed on FreeBSD. For shirou#1425
Generated on 15-CURRENT 5d62025d82a0. Fixes shirou#1425.
Copied from the arm64 definitions.
Currently fixing some bugs with the patch set. The Tv field in Utmpx should be a Timeval (which is a structure), but it's an uint64 in all the files for some reason. This is wrong and will lead to wrong results. Apparently this was changed in 2fd3f03 and I don't know why. |
Also note that the utmp structure no longer exists, it appears to be a legacy of FreeBSD 9. |
Thank you for your contribution! So are you still trying to edit this PR related to
Yes, it is just for a compatibility. But, perhaps, we can remove because FreeBSD 9 was released 10 years ago. |
I'm not sure what to do here. The
Maybe that would be a good idea indeed. |
When I run build test by
I found #709 and remember why Regarding the |
For #1425. This enables gopsutil to work on riscv64 FreeBSD.
I also fixed an include directive so mktypes.sh would succeed.